[meta] Build x86 Linux binaries on Ubuntu 20.04, for older (more compatible) glibc #760
Conversation
There was a problem hiding this comment.
This will help people on Ubuntu 20.04, as well as any compatible GLibC version.
Ubuntu 20.04 has glibc 2.31, per https://packages.ubuntu.com/focal-updates/glibc-source AND https://en.wikipedia.org/w/index.php?title=Glibc&oldid=1168675612#Version_history.
I dunno if that GLibC version is back-compatible at all/didn't make breaking changes relative to some slightly older GLibC version? (We know it doesn't address AlmaLinux/RockyLinux/Red Hat family 8 or 9, apparently. Per discussions and testing in those two issues.)
But this should be forward compatible with GLibC 2.31 and newer. It will help some people. Including apparently Ubuntu 20.04 users, which is kind of a big deal, IMO.
I dunno if we want to land this with a different commit message and/or PR name, but for building the main Linux x86 binaries on older Ubuntu, I'm definitely down for that. Hence this approve. 👍
|
Suggested changelog note, and/or commit message and/or PR title: "Build x86 Linux binaries on Ubuntu 20.04, for older (more compatible) glibc" |
|
@confused-Techie would you want to update the PR title, and/or do you mind if I update it? I think this would be neat to merge soon, since it basically enables Ubuntu 20.04 users to start using the Rolling as soon as we merge this. But a more technically precise PR title --> merge commit title could be good when looking back on this in the change. history and wondering what it's about?? Just mentioning glibc is already a pretty good clue though, TBH. |
|
Ahh totally slipped my mind to make those changes, I'll do that right now! Thanks for the reminder! |
confused-Techie
changed the title
|
@DeeDeeG Fixed the naming for this one, and with your approval I can go ahead and merge, just wanting to double check if everything looks alright to you now |
|
@confused-Techie yep, looks good! Might be overly technical or overwhelming to some, they might tune it out instead of it being helpful, but I think it's precise... "fix glibc nonsense" has no downside about over-complicating it, so in hindsight either is fine. (What people tl;dr can't help them :/ I feel like either less is more or more is more here, it's a subjective call.) /overthinking But either way, Looks Good To Me ™️ ! |
|
@DeeDeeG Yeah I think the precision is at just the right level here lol. |
Based on the information here it seems possible such a simple change can properly fix this issue for Linux users above Ubuntu 18.04.
This is a partial solution to the reported issues like this, as it won't fix issues running on RHEL8, but should hopefully fix the issue for at least the latest builds.
This can always been seen as an intermediary step, if we would like to bring support for older versions as well.
Relates to #733