Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog update for v1.110.0 #764

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Changelog update for v1.110.0 #764

merged 7 commits into from
Oct 16, 2023

Conversation

confused-Techie
Copy link
Member

Here's our monthly changelog updates.
With the lack of changes that modify core functionality I've brought up if we want to not jump so far ahead in versioning this time around, just to see if others are on board.

But of course that being subject to change, this gets all of our changelog updates in for now.

@confused-Techie confused-Techie changed the title Changelog update for v1.109.1 or v1.110.0 Changelog update for v1.110.0 Oct 15, 2023
Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe tweak the node-gyp bump changelog text?

CHANGELOG.md Outdated Show resolved Hide resolved
packages/welcome/lib/changelog-view.js Outdated Show resolved Hide resolved
Co-authored-by: DeeDeeG <DeeDeeG@users.noreply.github.com>
@confused-Techie
Copy link
Member Author

@DeeDeeG Got those changes in, thanks for catching that!

@DeeDeeG
Copy link
Member

DeeDeeG commented Oct 16, 2023

@DeeDeeG Got those changes in, thanks for catching that!

I made the changes for packages/welcome/lib/changelog-view.js as well, looks like the change for that file is not committed?

confused-Techie and others added 2 commits October 15, 2023 17:13
Co-authored-by: DeeDeeG <DeeDeeG@users.noreply.github.com>
Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Rubber-stamp approve" seems basically reasonable, content is text only so unlikely to have problems. (CI has been looking good, too.)

I haven't verified everything in here, but it's good to have a changelog! Approving formally for the process mostly.

@confused-Techie confused-Techie merged commit 083069d into master Oct 16, 2023
98 of 99 checks passed
@confused-Techie confused-Techie deleted the changelog-updates branch October 16, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants