Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.110.0 #766

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Release v1.110.0 #766

merged 3 commits into from
Oct 16, 2023

Conversation

confused-Techie
Copy link
Member

As title says.

Relates to #765

@DeeDeeG
Copy link
Member

DeeDeeG commented Oct 16, 2023

Dunno how big a deal this test failure is, I'm betting not very?

find-install-method main
  it Returns developer instance if applicable
    Expected 'Spec Mode' to be 'Developer Instance'.
      at jasmine.Spec.<anonymous> (/home/runner/work/pulsar/pulsar/node_modules/pulsar-updater/spec/find-install-method-spec.js:14:34)

https://github.com/pulsar-edit/pulsar/actions/runs/6527478245/job/17722644597?pr=766#step:10:42

This happened last Regular release PR as well: https://github.com/pulsar-edit/pulsar/actions/runs/6205040177/job/16847918274

I think Regular version numbers are just an edge case that the test doesn't handle right at the moment.

package.json Outdated Show resolved Hide resolved
confused-Techie and others added 2 commits October 15, 2023 21:29
Co-authored-by: DeeDeeG <DeeDeeG@users.noreply.github.com>
@confused-Techie
Copy link
Member Author

@DeeDeeG Thanks for making it easy to fix the version number here!

But like you said approvals aren't really required on these ones, so I'll just go ahead and merge this one.

Thanks for all the help in getting things put together this time around!

@confused-Techie confused-Techie merged commit 0361439 into master Oct 16, 2023
6 checks passed
@confused-Techie confused-Techie deleted the v1.110.0-release branch October 16, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants