CI: Build binaries for tag pushes (GitHub Actions) #782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue or RFC Endorsed by Pulsar's Maintainers
We discussed it on Discord, starting here: https://discord.com/channels/992103415163396136/992103415163396139/1163359940660953119
Description of the Change
Run the "build Pulsar binaries" workflow for tag pushes too, not just branch pushes and PRs.
Allows us to get signed macOS intel binaries out of the usual version bump + release flow we do for Regular releases.
(Bonus: The "make signed bins on tag pushes" approach will now be more consistent across CI providers. Creating or pushing a tag triggers it across both Cirrus and GitHub Actions with this change. This should make the task of triggering signed binary builds during Regular release more predictable -- just make sure you tag the version during release. Easy enough, I think?)
Alternate Designs
write
access to this repo.master
branch (Rolling releases) and the ones associated with a tag (Regular Releases). Basically, only Release bins are signed.Possible Drawbacks
None anticipated.
(Might make putting out Regular releases too easy???)
Verification Process
We could push a random tag with this change on it and see if it signs the macOS bins or not? I guess?
This change matches with the docs (https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore, https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet), so as long as this doesn't error as invalid syntax, I think it should "just work"™️?
Release Notes
N/A CI-only change. But "Build signed macOS binaries on tag pushes, not just
master
branch pushes (GitHub Actions)"