Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update github to v0.36.19-pretranspiled (fix silent failure when inputting a token with incorrect scopes) #838

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Dec 16, 2023

Includes the following github package Pull Request:

(Take a look at that PR for details, it has screenshots, BTW! - author of said PR)


This is a fix to address most if not all of the complaints surrounding a lacking UI/User Experience we've had around entering a PAT token into the github package for Pulsar -- it silently failed if you had wrong scopes. Too few scopes? Fail. Too many scopes? Believe it or not, fail.

  • This allows "excessive" (parent) scopes of the ones we actually want, since it was a common stumbling block for our users. They will be warned in the console about this, at least.
  • It actually shows something in the UI telling you you're missing some scopes on the token, if that's the case!
    • The (first) precise missing scope (out of the array) is logged in the console, with the UI hint telling you to look there for details.
  • Reduce one of the required scopes from repo to public_repo -- use this if you know you don't need to interact with private repos or push updates to GitHub Actions workflow .yml/.yaml files (since the former requires full repo scope, an the latter requires worfklow scope, which implies full repo scope).

This does not include PR https://github.com/pulsar-edit/github/pull/39, which was merged, but reverted at the last minute, as it had not been tested by anyone other than me at the time I tagged the latest github package version.

Includes the following github Pull Request:
PR 38 ("allow parent scopes")
@DeeDeeG DeeDeeG changed the title deps: Update github to v0.36.19-pretranspiled (fix silent failure on inputting a token with incorrect scopes) deps: Update github to v0.36.19-pretranspiled (fix silent failure when inputting a token with incorrect scopes) Dec 16, 2023
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Lets hope these changes get us everything we are wanting!

@confused-Techie confused-Techie merged commit 3cc30ce into master Dec 16, 2023
99 checks passed
@DeeDeeG DeeDeeG deleted the update-github-package branch December 18, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants