Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppm: Update ppm to commit 0bc207133b26de82aa28500e #845

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Dec 19, 2023

Includes the following ppm Pull Request:


This fix is a follow-up to the other recent ppm bump here at the core repo: #842

Includes ppm Pull Request 118 "Fix placement of setTimeout"
@DeeDeeG
Copy link
Member Author

DeeDeeG commented Dec 19, 2023

For the record, as a reminder of how to bump the submodule and do these ppm bumps:

  • git submodule update --remote ppm
  • git add ppm
  • git commit

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for putting this together!

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Dec 19, 2023

I'll re-run tests. I'm surprised any of them failed, but they could just be flakes.

I'm okay if this merges without the tests being green, but I'll personally try and get them green real quick... (Of course the binary build takes a while, sigh.)

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Dec 19, 2023

Yeah, I dunno what was up. Those CI jobs just said "This job has failed" and there were no logs. On just the macOS jobs on two different workflows. Weird.

They passed when re-ran. It's GitHub's problem, not mine to worry about!

Merging, thank you for the review!

@DeeDeeG DeeDeeG merged commit ef5c1da into master Dec 19, 2023
99 checks passed
@DeeDeeG DeeDeeG deleted the update-ppm branch January 12, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants