Default to no emoji when rendering Markdown

[savetheclocktower]

Identify the Bug

I saw this linter message when I opened the package-backend project and grew curious:

Turns out that emoji is an interpretation of :@.

I am guessing that most people who render Markdown would not expect that the character sequence :@ would, in all cases, be converted to an emoji. So let's make that an opt-in feature.

Description of the Change

Change the default for useDefaultEmoji in atom.ui.markdown.render to false.

Alternate Designs

I thought about removing this option altogether out of spite, but I calmed down.

Possible Drawbacks

Nah.

Verification Process

In the devtools console, run

atom.notifications.addError("foo", { description: ":@" });

and inspect the output. On master it'll be a smiley; on this PR branch it'll be the literal text :@.

Release Notes

Switch default to false for converting ASCII emoticons to emoji when rendering Markdown.

[confused-Techie]

This looks fine, as it's a simple change.

But since markdown-preview expects to be able to use emojis, would you mind added the option there to enable emojis?

Should be ./packages/markdown-preview/lib/renderer.js, lines 46, and 78

[confused-Techie]

Looks awesome to me!
Lets just wait for some tests to run, then I think we are good to merge