Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing spec #902

Merged

Conversation

savetheclocktower
Copy link
Contributor

No clue how this got through CI on the PR branch, but a spec is failing now solely because it is not inheriting a default value from a configuration. All that's needed is to explicitly set the defaults in the test, so that's what I've done.

@savetheclocktower
Copy link
Contributor Author

Check that — the defaults needed to be set explicitly because the language-javascript package hadn't been activated, so none of the defaults were applied in the first place. This confirms that the test failure is entirely a case of developer error when writing specs. The developer is me. I am that person.

@DeeDeeG
Copy link
Member

DeeDeeG commented Jan 30, 2024

Why is our CI like this?

How did this only fail on master branch?? 🤔

(I'd be more surprised to get an actual answer than not at this point, TBH. "CI mysteries" is easily believable. Some specific yet explainable voodoo seems more far-fetched.)

@savetheclocktower
Copy link
Contributor Author

It was failing for me locally, too, once I checked. Sigh.

@savetheclocktower savetheclocktower merged commit ca25930 into pulsar-edit:master Jan 30, 2024
103 checks passed
@savetheclocktower savetheclocktower deleted the tree-sitter-hotfix branch January 30, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants