Skip to content

Commit

Permalink
fix: use direct return, add ToDo comment
Browse files Browse the repository at this point in the history
  • Loading branch information
laminne committed Jul 27, 2024
1 parent ab5d965 commit 2751277
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
1 change: 1 addition & 0 deletions pkg/timeline/adaptor/controller/timeline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ export class TimelineController {
id: v.getID(),
name: v.getName(),
nickname: v.getNickname(),

Check warning on line 147 in pkg/timeline/adaptor/controller/timeline.ts

View check run for this annotation

Codecov / codecov/patch

pkg/timeline/adaptor/controller/timeline.ts#L142-L147

Added lines #L142 - L147 were not covered by tests
// ToDo: fill avatar URL
avatar: '',
};
});

Check warning on line 151 in pkg/timeline/adaptor/controller/timeline.ts

View check run for this annotation

Codecov / codecov/patch

pkg/timeline/adaptor/controller/timeline.ts#L149-L151

Added lines #L149 - L151 were not covered by tests
Expand Down
7 changes: 1 addition & 6 deletions pkg/timeline/service/fetchMember.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ export class FetchListMemberService {
}

Check warning on line 19 in pkg/timeline/service/fetchMember.ts

View check run for this annotation

Codecov / codecov/patch

pkg/timeline/service/fetchMember.ts#L18-L19

Added lines #L18 - L19 were not covered by tests
const unwrappedAccountID = Result.unwrap(list);

const accounts = await this.accountModule.fetchAccounts(unwrappedAccountID);
if (Result.isErr(accounts)) {
return accounts;
}

return Result.ok(Result.unwrap(accounts));
return await this.accountModule.fetchAccounts(unwrappedAccountID);
}
}

0 comments on commit 2751277

Please sign in to comment.