-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add base for services #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KisaragiEffective
previously requested changes
Sep 25, 2023
m1sk9
requested changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terraform の設定ファイルは cloudflare_records
でしか触ったことがないのでわかりません. 詳しい人にレビューを託します.
m1sk9
previously approved these changes
Sep 25, 2023
MikuroXina
force-pushed
the
services-base
branch
from
September 25, 2023 17:13
7c3cfa1
to
74fa8fd
Compare
KisaragiEffective
previously requested changes
Sep 26, 2023
MikuroXina
force-pushed
the
services-base
branch
from
September 26, 2023 14:02
57220f4
to
b857d76
Compare
Terraform Cloud Plan Output
|
Colk-tech
previously approved these changes
Sep 26, 2023
Co-authored-by: ITO Manaki (Colk) <53868423+Colk-tech@users.noreply.github.com>
laminne
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked:
ToDo: