Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add base for services #22

Merged
merged 25 commits into from
Sep 27, 2023
Merged

feat: Add base for services #22

merged 25 commits into from
Sep 27, 2023

Conversation

MikuroXina
Copy link
Contributor

@MikuroXina MikuroXina commented Sep 25, 2023 •
edited
Loading

Worked:

  • Move hello as a service
  • Add staging terraform
  • Add staging workflows

ToDo:

  • Register Terraform account
  • Set Terraform API token to secrets of this repsitory

KisaragiEffective
KisaragiEffective previously requested changes Sep 25, 2023
View reviewed changes
.github/actions/list_dockerfile/action.yml Outdated Show resolved Hide resolved
m1sk9
m1sk9 requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@m1sk9 m1sk9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform の設定ファイルは cloudflare_records でしか触ったことがないのでわかりません. 詳しい人にレビューを託します.

.github/workflows/staging-apply.yaml Outdated Show resolved Hide resolved
m1sk9
m1sk9 previously approved these changes Sep 25, 2023
View reviewed changes
KisaragiEffective
KisaragiEffective previously requested changes Sep 26, 2023
View reviewed changes
.github/actions/list_dockerfile/action.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

Terraform Cloud Plan Output

Plan: 9 to add, 0 to change, 0 to destroy.

Terraform Cloud Plan

Colk-tech
Colk-tech previously approved these changes Sep 26, 2023
View reviewed changes
.github/workflows/hadolint.yaml Outdated Show resolved Hide resolved
@MikuroXina @Colk-tech
Add newline
97017e2 
Co-authored-by: ITO Manaki (Colk) <53868423+Colk-tech@users.noreply.github.com>
laminne
laminne approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@laminne laminne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikuroXina MikuroXina enabled auto-merge (squash) September 26, 2023 16:26
@MikuroXina MikuroXina mentioned this pull request Sep 26, 2023
Closed
@MikuroXina MikuroXina merged commit c2ae91f into main Sep 27, 2023
2 checks passed
@MikuroXina MikuroXina deleted the services-base branch September 27, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laminne laminne laminne approved these changes

@m1sk9 m1sk9 m1sk9 left review comments

@KisaragiEffective KisaragiEffective Awaiting requested review from KisaragiEffective

@Colk-tech Colk-tech Awaiting requested review from Colk-tech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MikuroXina @laminne @KisaragiEffective @Colk-tech @m1sk9