Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Proposal: Standardize file names to the format <verb><Domain>[Context] #250

Closed
wants to merge 5 commits into from

Conversation

Allianaab2m
Copy link
Member

What does this PR do?

これは提案段階のPull Requestです.

  • モデルおよびサービスのファイル名の形式を変更できるものに関して<verb><Domain>[Context].tsに統一
  • クラス名の形式を<Verb><Domain>Serviceに統一

Additional information

ref:

@Allianaab2m Allianaab2m self-assigned this Mar 31, 2024
Copy link
Member

@nanai10a nanai10a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg/notes/mod.ts Outdated Show resolved Hide resolved
pkg/accounts/mod.ts Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

モデル名が AccountFollow なので accountFollow になると思います. ただ, follow を名詞的に扱って良いのか少し疑問です. その場合は, モデル名の命名の問題になります.

pkg/accounts/adaptor/controller/account.ts Outdated Show resolved Hide resolved
@m1sk9 m1sk9 closed this May 12, 2024
@m1sk9 m1sk9 deleted the feat/dev-185-patternA branch May 25, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants