Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Proposal: Standardize file names to the format <verb>[Context] #251

Closed
wants to merge 5 commits into from

Conversation

Allianaab2m
Copy link
Member

What does this PR do?

これは提案段階のPull Requestです.

  • モデルおよびサービスのファイル名の形式を変更できるものに関して<verb>[Context].tsに統一
  • クラス名の形式を<Verb>Serviceに統一
  • FetchServiceなど,外部Moduleからimportしたときに名前が被る場合は,Fetch<Domain>Serviceとなるようにimport aliasを付ける

Additional information

ref:

@Allianaab2m Allianaab2m self-assigned this Mar 31, 2024
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 49.36709% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 46.62%. Comparing base (0cbecc8) to head (050e049).
Report is 70 commits behind head on main.

Files Patch % Lines
pkg/notes/mod.ts 0.00% 16 Missing ⚠️
pkg/accounts/mod.ts 0.00% 12 Missing ⚠️
pkg/accounts/adaptor/controller/account.ts 71.42% 8 Missing ⚠️
pkg/notes/adaptor/controller/note.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   45.72%   46.62%   +0.90%     
==========================================
  Files          37       38       +1     
  Lines        4074     4124      +50     
  Branches      256      271      +15     
==========================================
+ Hits         1863     1923      +60     
+ Misses       2211     2201      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nanai10a nanai10a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 外部モジュールからの import を再命名するという部分は網羅的に見ていないので修正はたまたま見つけた 1 点のみですが, 多分他にもあるのかなーと見ています

pkg/accounts/service/verifyToken.ts Outdated Show resolved Hide resolved
pkg/notes/service/fetch.test.ts Outdated Show resolved Hide resolved
@Allianaab2m
Copy link
Member Author

close. #373

@m1sk9 m1sk9 deleted the feat/dev-185-patternB branch May 25, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants