Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EditAccountService): changed edit method to update repository #263

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

Allianaab2m
Copy link
Member

What does this PR do?

  • EditAccountServiceがAccountRepositoryのEditメソッドを使い,データストアの値を書き換えるように
  • テストケースのリファクタ

Copy link

github-actions bot commented Apr 4, 2024

@Allianaab2m
To merge a pull request, the title must be according to Conventional Commits.
Click the "Edit" button at the top right of the page to change the title, please.

Available types:
  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

@Allianaab2m Allianaab2m changed the title feat(EditAccountService): feat(EditAccountService): changed edit method to update repository Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 48.40%. Comparing base (90c9f25) to head (ba00825).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/accounts/service/editAccount.ts 82.60% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
+ Coverage   46.39%   48.40%   +2.01%     
==========================================
  Files          38       38              
  Lines        4156     4179      +23     
  Branches      271      306      +35     
==========================================
+ Hits         1928     2023      +95     
+ Misses       2228     2156      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/accounts/service/editAccount.test.ts Outdated Show resolved Hide resolved
@Allianaab2m Allianaab2m merged commit b0f1f4c into main Apr 4, 2024
5 checks passed
@Allianaab2m Allianaab2m deleted the feat/dev-169 branch April 4, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants