Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace DI in accounts pkg with Ether #370

Merged
merged 4 commits into from
May 17, 2024
Merged

refactor: Replace DI in accounts pkg with Ether #370

merged 4 commits into from
May 17, 2024

Conversation

MikuroXina
Copy link
Contributor

What does this PR do?

My library mini-fn has a module Ether, the dependency injection helper. It uses Symbols to determine what are resolved or not.

At first, I'd replaced manual DI in accounts package with Ether as experiment. It would be nicer than calling their constructor of services directly.

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 94.27083% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 65.65%. Comparing base (73b09d7) to head (3c36283).

Files Patch % Lines
pkg/accounts/adaptor/repository/prisma.ts 0.00% 20 Missing ⚠️
pkg/accounts/service/fetchAccountFollow.ts 93.33% 1 Missing ⚠️
pkg/id/mod.ts 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   64.07%   65.65%   +1.58%     
==========================================
  Files          44       44              
  Lines        4699     4965     +266     
  Branches      356      379      +23     
==========================================
+ Hits         3011     3260     +249     
- Misses       1688     1705      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MikuroXina MikuroXina merged commit 770ac8b into main May 17, 2024
6 checks passed
@MikuroXina MikuroXina deleted the ether branch May 17, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants