Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define medium model, media repository #396

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

laminne
Copy link
Member

@laminne laminne commented May 29, 2024

What does this PR do?

  • メディアのドメインモデルの定義
  • MediaRepositoryの定義

Additional information

  • S3互換ストレージでどのようにオブジェクトを特定するのかが不明だったのでpath等は追加していません

@laminne laminne added the T: feature New feature label May 29, 2024
@laminne laminne requested a review from MikuroXina May 29, 2024 04:34
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 89 lines in your changes are missing coverage. Please review.

Project coverage is 64.39%. Comparing base (794a861) to head (16fc801).

Files Patch % Lines
pkg/drive/model/medium.ts 0.00% 77 Missing ⚠️
pkg/drive/model/repository.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   65.52%   64.39%   -1.13%     
==========================================
  Files          47       49       +2     
  Lines        5076     5165      +89     
  Branches      387      389       +2     
==========================================
  Hits         3326     3326              
- Misses       1750     1839      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/drive/model/medium.ts Outdated Show resolved Hide resolved
@laminne laminne merged commit ec973a5 into main May 29, 2024
3 of 5 checks passed
@laminne laminne deleted the feat/dev-226-drive-model branch May 29, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants