Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notes): implement bookmark API handler #400

Merged
merged 6 commits into from
Jun 2, 2024
Merged

feat(notes): implement bookmark API handler #400

merged 6 commits into from
Jun 2, 2024

Conversation

Allianaab2m
Copy link
Member

What does this PR do?

Bookmark APIのハンドラーを追加しました.

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 65.70%. Comparing base (5f0e6a6) to head (fd33d9e).
Report is 14 commits behind head on main.

Files Patch % Lines
pkg/notes/mod.ts 0.00% 61 Missing ⚠️
pkg/notes/adaptor/controller/bookmark.ts 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   65.82%   65.70%   -0.13%     
==========================================
  Files          44       52       +8     
  Lines        4975     5418     +443     
  Branches      382      417      +35     
==========================================
+ Hits         3275     3560     +285     
- Misses       1700     1858     +158     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/notes/mod.ts Outdated Show resolved Hide resolved
Copy link
Member

@laminne laminne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

プログラム内のToDoコメントは英語でお願いします 🙏🏻

@laminne laminne merged commit 4e30b98 into main Jun 2, 2024
3 of 5 checks passed
@laminne laminne deleted the feat/dev-219 branch June 2, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants