Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Account Timeline #428

Merged
merged 9 commits into from
Jun 11, 2024
Merged

feat: Account Timeline #428

merged 9 commits into from
Jun 11, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Jun 8, 2024

What does this PR do?

  • AccountTimelineServiceの実装 (アカウントタイムライン取得の実装)
  • NoteVisibilityServiceの実装 (可視性チェックの実装)
    • フォロー/フォロワー情報の取得のAPI実装 (Accountモジュール)
    • Intermodule::AccountModule へのインタフェース追加

Additional information

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 38.06452% with 480 lines in your changes missing coverage. Please review.

Project coverage is 61.30%. Comparing base (867125f) to head (5023886).
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/timeline/adaptor/controller/timeline.ts 0.00% 89 Missing ⚠️
pkg/accounts/adaptor/controller/account.ts 11.36% 78 Missing ⚠️
pkg/timeline/adaptor/repository/prisma.ts 0.00% 74 Missing ⚠️
pkg/timeline/router.ts 0.00% 58 Missing ⚠️
pkg/intermodule/account.ts 18.64% 48 Missing ⚠️
pkg/timeline/mod.ts 0.00% 46 Missing ⚠️
pkg/accounts/mod.ts 32.30% 44 Missing ⚠️
pkg/timeline/adaptor/validator/timeline.ts 0.00% 38 Missing ⚠️
pkg/timeline/service/account.ts 96.96% 2 Missing ⚠️
pkg/timeline/service/noteVisibility.ts 96.36% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   64.43%   61.30%   -3.13%     
==========================================
  Files          54       63       +9     
  Lines        5682     6456     +774     
  Branches      420      456      +36     
==========================================
+ Hits         3661     3958     +297     
- Misses       2021     2498     +477     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laminne laminne requested a review from MikuroXina June 9, 2024 06:50
@laminne laminne marked this pull request as ready for review June 9, 2024 06:50
@laminne laminne enabled auto-merge (squash) June 9, 2024 06:51
pkg/accounts/adaptor/controller/account.ts Outdated Show resolved Hide resolved
pkg/intermodule/account.ts Outdated Show resolved Hide resolved
pkg/timeline/adaptor/controller/timeline.ts Outdated Show resolved Hide resolved
pkg/timeline/adaptor/repository/prisma.ts Outdated Show resolved Hide resolved
pkg/timeline/service/account.ts Outdated Show resolved Hide resolved
pkg/accounts/adaptor/controller/account.ts Outdated Show resolved Hide resolved
pkg/accounts/adaptor/controller/account.ts Outdated Show resolved Hide resolved
pkg/timeline/adaptor/controller/timeline.ts Outdated Show resolved Hide resolved
pkg/timeline/adaptor/repository/dummy.ts Outdated Show resolved Hide resolved
pkg/timeline/adaptor/repository/dummy.ts Show resolved Hide resolved
pkg/timeline/adaptor/repository/dummy.ts Outdated Show resolved Hide resolved
pkg/timeline/adaptor/controller/timeline.ts Outdated Show resolved Hide resolved
pkg/timeline/adaptor/controller/timeline.ts Outdated Show resolved Hide resolved
pkg/timeline/adaptor/controller/timeline.ts Outdated Show resolved Hide resolved
pkg/timeline/adaptor/repository/dummy.ts Outdated Show resolved Hide resolved
@laminne laminne merged commit b40d68d into main Jun 11, 2024
3 of 5 checks passed
@laminne laminne deleted the feat/bck-225-account-notes branch June 11, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants