Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace ID<NoteID> to ID<Note> #436

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

laminne
Copy link
Member

@laminne laminne commented Jun 11, 2024

What does this PR do?

  • ID<NoteID>ID<Note>に置き換えました.

Additional information

@laminne laminne requested a review from MikuroXina June 11, 2024 09:41
@laminne laminne added the T: improvement Improvement of functions, etc. label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 18 lines in your changes missing coverage. Please review.

Project coverage is 61.20%. Comparing base (c534f14) to head (38ea128).

Files Patch % Lines
pkg/notes/adaptor/repository/prisma.ts 0.00% 9 Missing ⚠️
pkg/notes/adaptor/controller/bookmark.ts 0.00% 3 Missing ⚠️
pkg/notes/adaptor/controller/note.ts 0.00% 2 Missing ⚠️
pkg/timeline/adaptor/controller/timeline.ts 0.00% 2 Missing ⚠️
pkg/timeline/adaptor/repository/prisma.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   61.23%   61.20%   -0.04%     
==========================================
  Files          62       62              
  Lines        6439     6423      -16     
  Branches      456      456              
==========================================
- Hits         3943     3931      -12     
+ Misses       2496     2492       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laminne laminne merged commit 09a3d00 into main Jun 11, 2024
5 of 6 checks passed
@laminne laminne deleted the fix/bck-236-replace-noteid-type branch June 11, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: improvement Improvement of functions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants