Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl home timeline #440

Merged
merged 7 commits into from
Jun 15, 2024
Merged

feat: impl home timeline #440

merged 7 commits into from
Jun 15, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Jun 13, 2024

What does this PR do?

  • ホームタイムライン用のRepository, Service, ハンドラ, Intermoduleの定義と実装
  • Redis(Valkey)用のライブラリのインストールioredis
  • compose.ymlにValkeyの設定を追加

Additional information

  • ToDo: Intermoduleはフォロー解除時のDropの実装がまだです
  • ToDo: Timelineモジュールのハンドラを認証必須にする
  • NOTE: Intermodule専用のエンドポイントはControllerを実装しないハンドラのみの実装としました

@laminne laminne added T: feature New feature P: high T: improvement Improvement of functions, etc. labels Jun 13, 2024
@laminne laminne requested a review from MikuroXina June 13, 2024 14:10
@laminne laminne self-assigned this Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 51.10664% with 243 lines in your changes missing coverage. Please review.

Project coverage is 60.57%. Comparing base (5b094f3) to head (cc5bb3c).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/timeline/mod.ts 0.00% 64 Missing ⚠️
pkg/timeline/adaptor/repository/valkeyCache.ts 0.00% 55 Missing ⚠️
pkg/timeline/router.ts 0.00% 51 Missing ⚠️
pkg/intermodule/timeline.ts 0.00% 30 Missing ⚠️
pkg/timeline/adaptor/repository/prisma.ts 0.00% 23 Missing ⚠️
pkg/timeline/adaptor/repository/dummyCache.ts 82.75% 10 Missing ⚠️
pkg/timeline/adaptor/repository/dummy.ts 87.87% 4 Missing ⚠️
pkg/timeline/service/push.ts 92.15% 4 Missing ⚠️
pkg/timeline/service/home.ts 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   61.07%   60.57%   -0.51%     
==========================================
  Files          63       69       +6     
  Lines        6595     7059     +464     
  Branches      461      488      +27     
==========================================
+ Hits         4028     4276     +248     
- Misses       2567     2783     +216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/intermodule/timeline.ts Outdated Show resolved Hide resolved
pkg/timeline/adaptor/repository/dummyCache.ts Outdated Show resolved Hide resolved
pkg/timeline/adaptor/repository/prisma.ts Outdated Show resolved Hide resolved
pkg/timeline/mod.ts Outdated Show resolved Hide resolved
pkg/timeline/model/repository.ts Outdated Show resolved Hide resolved
pkg/timeline/service/home.ts Outdated Show resolved Hide resolved
pkg/timeline/service/noteVisibility.ts Outdated Show resolved Hide resolved
pkg/timeline/service/push.ts Outdated Show resolved Hide resolved
pkg/timeline/service/push.ts Outdated Show resolved Hide resolved
pkg/timeline/adaptor/repository/dummyCache.ts Outdated Show resolved Hide resolved
pkg/timeline/service/home.ts Outdated Show resolved Hide resolved
@laminne laminne enabled auto-merge (squash) June 15, 2024 12:58
@laminne laminne merged commit 89f3547 into main Jun 15, 2024
3 of 5 checks passed
@laminne laminne deleted the feat/bck-240-home-timeline branch June 15, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: high T: feature New feature T: improvement Improvement of functions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants