Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl fetch list members #591

Merged
merged 5 commits into from
Jul 27, 2024
Merged

feat: impl fetch list members #591

merged 5 commits into from
Jul 27, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Jul 26, 2024

What does this PR do?

close #563

  • リストメンバー(assignees)を取得できるエンドポイントの実装
  • APIリファレンスの更新

Additional information

  • spec.pulsate.devにはドキュメントがなかった(定義漏れ?)ので後で追加します

@laminne laminne added the T: feature New feature label Jul 26, 2024
@laminne laminne linked an issue Jul 26, 2024 that may be closed by this pull request
3 tasks
@laminne laminne requested review from MikuroXina and m1sk9 July 26, 2024 11:21
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 80 lines in your changes missing coverage. Please review.

Project coverage is 53.43%. Comparing base (e436121) to head (2751277).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/timeline/adaptor/validator/timeline.ts 0.00% 24 Missing ⚠️
pkg/timeline/router.ts 0.00% 23 Missing ⚠️
pkg/timeline/adaptor/controller/timeline.ts 0.00% 20 Missing ⚠️
pkg/timeline/mod.ts 0.00% 11 Missing ⚠️
pkg/timeline/service/fetchMember.ts 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
- Coverage   53.55%   53.43%   -0.13%     
==========================================
  Files         118      121       +3     
  Lines        8829     8978     +149     
  Branches      791      796       +5     
==========================================
+ Hits         4728     4797      +69     
- Misses       4101     4181      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/intermodule/account.ts Outdated Show resolved Hide resolved
@laminne laminne requested a review from MikuroXina July 26, 2024 14:54
pkg/timeline/adaptor/controller/timeline.ts Show resolved Hide resolved
pkg/timeline/service/fetchMember.ts Outdated Show resolved Hide resolved
@laminne laminne merged commit f455e15 into main Jul 27, 2024
4 of 5 checks passed
@laminne laminne deleted the feat/563-fetch-list-member branch July 27, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: アカウントリストのメンバーを取得できるようにする
2 participants