Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: アカウントをID/Name両方で取得できるように #794

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Oct 24, 2024

close #785

What does this PR do?

  • GET /accounts/:idGET /accounts/:identifierに変更
    • IDまたはNameで取得できるように
  • APIドキュメントの更新
  • PrismaRepositoryの実装ミスで投稿を取得できない問題を修正
    • 同様の実装が数箇所あるはずなので別の箇所についてはIssueを立てて対処します

Additional information

@laminne laminne added the T: feature New feature label Oct 24, 2024
@laminne laminne self-assigned this Oct 24, 2024
@laminne laminne enabled auto-merge (squash) October 24, 2024 15:26
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.

Project coverage is 49.17%. Comparing base (eca4510) to head (c344eb5).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/accounts/mod.ts 0.00% 26 Missing ⚠️
pkg/accounts/adaptor/controller/account.ts 0.00% 25 Missing ⚠️
pkg/accounts/router.ts 0.00% 16 Missing ⚠️
pkg/timeline/adaptor/repository/prisma.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   49.41%   49.17%   -0.24%     
==========================================
  Files         149      149              
  Lines       13540    13614      +74     
  Branches     1051     1051              
==========================================
+ Hits         6691     6695       +4     
- Misses       6849     6919      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laminne laminne merged commit 66cf409 into main Oct 25, 2024
3 of 5 checks passed
@laminne laminne deleted the feat/785-get-account-by-note-or-id branch October 25, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: アカウントをIDでもnameでも取得できるようにする
2 participants