Skip to content

Commit

Permalink
Remove unused publish.goSdk config (#1006)
Browse files Browse the repository at this point in the history
These are never actually overridden so can be inlined to reduce
complexity of possible conditons.

Single reference to goSdk was in pulumi-kafka which had no effect. PR to
remove: pulumi/pulumi-kafka#459

Stacked on top of:
- #1003
  • Loading branch information
danielrbradley authored Jun 26, 2024
1 parent 05b8d58 commit 9069b70
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 28 deletions.
10 changes: 0 additions & 10 deletions provider-ci/internal/pkg/templates/bridged-provider.config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -153,16 +153,6 @@ publish:
# passed to the sdk input of pulumi-package-publisher
# This is overridden in pulumi-local to disable python
sdk: all
# goSdk is no longer needed as is not overridden in specific providers.
goSdk:
# Set to `true` to use the below configuration to push a new commit somewhere else.
usePush: true
# By default we'll push back to its own repository as a standalone, tagged commit.
repository: ${{ github.repository }}
baseRef: ${{ github.sha }}
source: sdk
path: sdk
additive: false

# Set a path for each language example to enable the test
# releaseVerification:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ jobs:
java-version: "#{{ .Config.toolVersions.java }}#"
node-version: "#{{ .Config.toolVersions.node }}#"
python-version: "#{{ .Config.toolVersions.python }}#"
#{{- if .Config.publish.goSdk.usePush }}#
publish_go_sdk:
name: publish_go_sdk
needs:
Expand All @@ -120,18 +119,17 @@ jobs:
shell: bash
- uses: pulumi/publish-go-sdk-action@v1
with:
repository: #{{ .Config.publish.goSdk.repository }}#
base-ref: #{{ .Config.publish.goSdk.baseRef }}#
source: #{{ .Config.publish.goSdk.source }}#
path: #{{ .Config.publish.goSdk.path }}#
repository: ${{ github.repository }}
base-ref: ${{ github.sha }}
source: sdk
path: sdk
version: ${{ needs.prerequisites.outputs.version }}
additive: #{{ .Config.publish.goSdk.additive }}#
additive: false
# Avoid including other language SDKs & artifacts in the commit
files: |
go.*
go/**
!*.tar.gz
#{{- end }}#
test:
name: test
needs:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ jobs:
with:
submodules: #{{ .Config.checkoutSubmodules }}#
#{{- end }}#
#{{- if .Config.publish.goSdk.usePush }}#
- name: Download Go SDK
uses: actions/download-artifact@v4
with:
Expand All @@ -137,22 +136,17 @@ jobs:
shell: bash
- uses: pulumi/publish-go-sdk-action@v1
with:
repository: #{{ .Config.publish.goSdk.repository }}#
base-ref: #{{ .Config.publish.goSdk.baseRef }}#
source: #{{ .Config.publish.goSdk.source }}#
path: #{{ .Config.publish.goSdk.path }}#
repository: ${{ github.repository }}
base-ref: ${{ github.sha }}
source: sdk
path: sdk
version: ${{ needs.prerequisites.outputs.version }}
additive: #{{ .Config.publish.goSdk.additive }}#
additive: false
# Avoid including other language SDKs & artifacts in the commit
files: |
go.*
go/**
!*.tar.gz
#{{- else }}#
- name: Add SDK version tag
run: git tag "sdk/v${{ needs.prerequisites.outputs.version }}" && git push origin
"sdk/v${{ needs.prerequisites.outputs.version }}"
#{{- end }}#
clean_up_release_labels:
name: Clean up release labels
Expand Down

0 comments on commit 9069b70

Please sign in to comment.