Skip to content

Conversation

SaraDPH
Copy link
Contributor

@SaraDPH SaraDPH commented Aug 15, 2025

This is a landing page for ads, focusing on the Azure users.
Secondary: highlight C# and also ARM,

@SaraDPH SaraDPH changed the title Add files via upload Azure Page 4 Ads Aug 15, 2025
@pulumi-bot
Copy link
Collaborator

- changing language to Azure and ARM
- changing code snippets from AWS to Azure
@SaraDPH SaraDPH added the area/www Enhancement and content requests for www.pulumi.com label Aug 15, 2025
@SaraDPH SaraDPH self-assigned this Aug 15, 2025
@pulumi-bot
Copy link
Collaborator

@SaraDPH
Copy link
Contributor Author

SaraDPH commented Aug 15, 2025

Why does the preview look empty?!

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

Copy link
Contributor

@asafashirov asafashirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@meagancojocar
Copy link
Collaborator

closing for now, re open if we are ready to get it across the line

@SaraDPH
Copy link
Contributor Author

SaraDPH commented Sep 26, 2025

@meagancojocar oops, I just forgot to merge, can it open and be merged?

Copy link
Contributor

claude bot commented Sep 29, 2025

This Azure landing page looks good overall with functional template improvements. However, there are several style guide violations and content issues that need to be addressed:

Critical Issues:

  • Missing newline at end of file (Line 280): content/gads/azure/index.md must end with a newline per AGENTS.md requirements

Style Guide Violations (per STYLE-GUIDE.md):

  • Line 21: "Azure Infrastructure you can Write, Reuse, and Test" should be sentence case: "Azure infrastructure you can write, reuse, and test"
  • Line 60: "Azure Resource Manager → Pulumi" should be sentence case
  • Line 24: Remove unnecessary bold formatting on "components" as it is not a UI element
  • Line 62: "Many Azure teams hit a wall with ARM templates" - consider more professional phrasing like "Many Azure teams find ARM templates limiting"
  • Line 63: Avoid superlative "far better", use "provides a more flexible experience"

Technical Issues:

  • Lines 29-50: C# code example has inconsistent indentation - some lines use 2 spaces, others 4 spaces
  • Line 41: Missing space after comma in "StorageV2","
  • Lines 76-88: Similar indentation inconsistencies in the second C# example

Template Implementation: The Hugo template changes look well-implemented with proper dynamic language option generation and good fallback behavior.

Action Items:

  1. Add newline at end of content/gads/azure/index.md
  2. Fix heading capitalization to follow sentence case rules
  3. Standardize code indentation (suggest 4 spaces for C#)
  4. Remove unnecessary bold formatting and superlatives
  5. Consider more professional alternative to "hit a wall"

The template functionality is solid, but the content needs these style fixes before merge.

@pulumi-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/www Enhancement and content requests for www.pulumi.com do-not-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants