Expose EncryptPlaintext method #599
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyeh
added
the
impact/no-changelog-required
pgavlin
requested changes
Nov 7, 2025
| }) | ||
| } | ||
|
|
||
| func EncryptPlaintext(ctx context.Context, encrypter Encrypter, plaintext []byte) ([]byte, error) { |
Member
There was a problem hiding this comment.
let's call this EncryptSecret for congruence with DecryptSecrets.
Suggested change
| func EncryptPlaintext(ctx context.Context, encrypter Encrypter, plaintext []byte) ([]byte, error) { | |
| func EncryptSecret(ctx context.Context, encrypter Encrypter, plaintext []byte) ([]byte, error) { |
This also needs a doc comment. A simple test would be great as well--making sure it round-trips should be sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose EncryptPlaintext to consumers of esc