Updating TS AWS Fargate Example #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toriancrane I think you'll need to end up needing to close this---some folks from Engineering submitted PR #1489, which was merged, to fix the |
|
@scottslowe I still need this reviewed because the other merge only fixed the name issue. I merged their change into mine, but I still think updating the supported regions should go in there too. |
scottslowe
approved these changes
Sep 8, 2023
|
@toriancrane Apologies for the delay on reviewing it. There's a couple of test failures, but they appear unrelated to these changes, so I've approved the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated instructions text to remove manual references to supported Fargate regions and added link to AWS documentation instead
Related to: