-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 #3846
Draft
danielrbradley
wants to merge
15
commits into
master
Choose a base branch
from
v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
V3 #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Found 2827 breaking changes: Resources
New resources:
New functions:
|
thomas11
added a commit
that referenced
this pull request
Jan 13, 2025
Extracted from the work on the `v3` branch: #3846 This has no impact until the major version is changed in the makefile.
7a5d418
to
ea3c033
Compare
3ff7827
to
928aa5c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Add script for generating a new major version.
Fix altered casing of "IP" from `IpAllocationMethod`.
Add new field (privateEndpointVNetPolicies) which is now populated by default in the new version of the VirtualNetwork resource. The value ("Disabled") was found by creating a VirtualNetwork manually and exporting as an ARM template in the portal.
Resolves #2749 but not completely yet. So far, these are the overrides that can be removed without any further changes, and `make schema` succeeds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3448
Note: when rebasing this branch, only keep
the firstthe hand-written commits, then re-rungen-major-version.sh
to generate subsequent commits.Here's the input to use for interactive rebase: