Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include the default version as an explicit version in v3 #3924

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Feb 4, 2025

Due to low confidence on the migration path in v2, we added all resource being used in the default version as explicit versions too.

With the improved aliasing approach from #3872, this is not required any more.

See the preview generation against the v3 branch: v3...dont-duplicate-default-as-explicit-v3-preview

This has a net reduction of 1,118,866 lines of SDK code and an uncompressed size reduction of just under 7% to deliver a 48% overall reduction for v3.

SDK v2 size v3 size new v3 size
dotnet 653M 363M 340M
nodejs 300M 166M 156M
python 717M 401M 376M

Copy link

github-actions bot commented Feb 4, 2025

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.03%. Comparing base (1a58192) to head (7b05641).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/versioning/gen.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3924   +/-   ##
=======================================
  Coverage   57.02%   57.03%           
=======================================
  Files          79       79           
  Lines       12548    12548           
=======================================
+ Hits         7156     7157    +1     
+ Misses       4841     4840    -1     
  Partials      551      551           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!!

@danielrbradley danielrbradley merged commit 84b62e5 into master Feb 4, 2025
24 checks passed
@danielrbradley danielrbradley deleted the dont-duplicate-default-as-explicit branch February 4, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants