Skip to content

Commit

Permalink
Fix verification tests (#2390)
Browse files Browse the repository at this point in the history
- Set location explicitly in the programs instead of assuming program
test will set it for us.
- Disable python as it currently breaks for pre-releases (see
pulumi/verify-provider-release#39)

Manual test run:
https://github.com/pulumi/pulumi-azure/actions/runs/10845914340/job/30097763444
- go fails because it's a prerelease being tested, but we can't skip it
yet when invoking directly (see
pulumi/ci-mgmt#1080)
  • Loading branch information
danielrbradley authored Sep 13, 2024
1 parent af5db62 commit 6c2b13f
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 12 deletions.
3 changes: 2 additions & 1 deletion .ci-mgmt.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ actions:
pulumiConvert: 1
releaseVerification:
nodejs: examples/topic
python: examples/eventhub-py
# Disable python until https://github.com/pulumi/verify-provider-release/issues/39 is addressed
# python: examples/eventhub-py
dotnet: examples/appservice-cs
go: examples/network-go
7 changes: 0 additions & 7 deletions .github/workflows/verify-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,6 @@ jobs:
directory: examples/topic
provider: azure
providerVersion: ${{ inputs.providerVersion }}
- name: Verify python release
uses: pulumi/verify-provider-release@v1
with:
runtime: python
directory: examples/eventhub-py
provider: azure
providerVersion: ${{ inputs.providerVersion }}
- name: Verify dotnet release
uses: pulumi/verify-provider-release@v1
with:
Expand Down
5 changes: 4 additions & 1 deletion examples/appservice-cs/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ class Program
static Task<int> Main(string[] args)
{
return Deployment.RunAsync(() => {
var resourceGroup = new ResourceGroup("appservice-rg");
var resourceGroup = new ResourceGroup("appservice-rg", new ResourceGroupArgs
{
Location = "WestUS",
});
var storageAccount = new Account("sa", new AccountArgs
{
Expand Down
2 changes: 1 addition & 1 deletion examples/eventhub-py/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import pulumi
from pulumi_azure import core, eventhub
resource_group = core.ResourceGroup('eventhub-py-example')
resource_group = core.ResourceGroup('eventhub-py-example', location='WestUS')

namespace = eventhub.EventHubNamespace('eventhub-py-eg',
resource_group_name=resource_group.name,
Expand Down
4 changes: 3 additions & 1 deletion examples/network-go/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ import (

func main() {
pulumi.Run(func(ctx *pulumi.Context) error {
rg, err := core.NewResourceGroup(ctx, "server-rg", nil)
rg, err := core.NewResourceGroup(ctx, "server-rg", &core.ResourceGroupArgs{
Location: pulumi.String("WestUS"),
})
if err != nil {
return err
}
Expand Down
4 changes: 3 additions & 1 deletion examples/topic/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
import * as azure from "@pulumi/azure";
import * as eventhub from "@pulumi/azure/eventhub";

const resourceGroup = new azure.core.ResourceGroup("test");
const resourceGroup = new azure.core.ResourceGroup("test", {
location: "WestUS",
});

const namespace = new eventhub.Namespace("test", {
resourceGroupName: resourceGroup.name,
Expand Down

0 comments on commit 6c2b13f

Please sign in to comment.