Skip to content

Commit

Permalink
Dont skip tests by default (#2011)
Browse files Browse the repository at this point in the history
Highly unexpected behaviour, I think it's much more natural to fail when
the required env vars are not set.

EDIT: Even that was unnecessary, azure sets that config by default:
https://www.pulumi.com/registry/packages/azure-native/installation-configuration/#configuration-options
  • Loading branch information
VenelinMartinov authored May 8, 2024
1 parent 6c5ab4f commit ced09a5
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions examples/examples_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,6 @@ func skipIfShort(t *testing.T) {
}
}

func getEnviron(t *testing.T) string {
env := os.Getenv("ARM_ENVIRONMENT")
if env == "" {
t.Skipf("Skipping test due to missing ARM_ENVIRONMENT environment variable")
}

return env
}

func getLocation(t *testing.T) string {
azureLocation := os.Getenv("ARM_LOCATION")
Expand All @@ -50,12 +42,10 @@ func getCwd(t *testing.T) string {
}

func getBaseOptions(t *testing.T) integration.ProgramTestOptions {
environ := getEnviron(t)
azureLocation := getLocation(t)
return integration.ProgramTestOptions{
Config: map[string]string{
"azure:environment": environ,
"azure:location": azureLocation,
"azure:location": azureLocation,
},
}
}
Expand Down

0 comments on commit ced09a5

Please sign in to comment.