Skip to content

Feat: Support SSH Agent named pipe on Windows runner#747

Merged
mjeffryes merged 1 commit intopulumi:masterfrom
KevinFairise2:feat/windows-ssh-agent-support
Sep 9, 2025
Merged

Feat: Support SSH Agent named pipe on Windows runner#747
mjeffryes merged 1 commit intopulumi:masterfrom
KevinFairise2:feat/windows-ssh-agent-support

Conversation

@KevinFairise2
Copy link
Copy Markdown
Contributor

Fixes #746

On Windows, SSH agent use a named pipe, \\.\pipe\openssh-ssh-agent by default.
This PR add some code to try to read that named pipe with winio when running on a Windows runner

@github-actions
Copy link
Copy Markdown

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@blampe
Copy link
Copy Markdown
Contributor

blampe commented May 5, 2025

Thank you for putting this together, @KevinFairise2!

Were you able to test this locally, and did it resolve your issue?

Normally I would ask for a quick test, but in this case that will involve spinning up Windows instances on CI, and I don't think this needs to be held up on that.

@blampe blampe added the awaiting-feedback Blocked on input from the author label May 22, 2025
@clarkb7
Copy link
Copy Markdown

clarkb7 commented Jul 18, 2025

@blampe I can test it. Can you link some instructions for creating and testing a Windows build? I've only found instructions for macos and Linux/WSL

@clarkb7
Copy link
Copy Markdown

clarkb7 commented Aug 18, 2025

I got help on slack for how to build/test.

screenshot of debugging session showing winio pipe being used
Screenshot 2025-08-18 120253
and of 1password ssh-agent recording the activity
image

summary of build/test
Can cross compile by setting GOOS=windows, and then manually add .exe extension.
or build on Windows via make provider if you have go and mingw.
then put new binary on PATH

$env:PATH="C:\Users\branden.clark\projects\pulumi-command\bin;$env:PATH"

you should see output like

using pulumi-resource-command from $PATH at C:\Users\branden.clark\projects\pulumi-command\bin\pulumi-resource-command.exe

@clarkb7
Copy link
Copy Markdown

clarkb7 commented Sep 2, 2025

@blampe sorry for the @, is there anything else holding up this PR?

@mjeffryes mjeffryes enabled auto-merge (squash) September 9, 2025 17:48
@mjeffryes mjeffryes merged commit df2818e into pulumi:master Sep 9, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-feedback Blocked on input from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ssh-agent authentication on Windows

4 participants