Feat: Support SSH Agent named pipe on Windows runner#747
Merged
mjeffryes merged 1 commit intopulumi:masterfrom Sep 9, 2025
Merged
Feat: Support SSH Agent named pipe on Windows runner#747mjeffryes merged 1 commit intopulumi:masterfrom
mjeffryes merged 1 commit intopulumi:masterfrom
Conversation
|
PR is now waiting for a maintainer to run the acceptance tests. |
Contributor
|
Thank you for putting this together, @KevinFairise2! Were you able to test this locally, and did it resolve your issue? Normally I would ask for a quick test, but in this case that will involve spinning up Windows instances on CI, and I don't think this needs to be held up on that. |
|
@blampe I can test it. Can you link some instructions for creating and testing a Windows build? I've only found instructions for macos and Linux/WSL |
|
@blampe sorry for the @, is there anything else holding up this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #746
On Windows, SSH agent use a named pipe,
\\.\pipe\openssh-ssh-agentby default.This PR add some code to try to read that named pipe with
winiowhen running on a Windows runner