Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot specify Managed Node Group DiskSize when a launch template is created #1228

Closed
JustASquid opened this issue Jul 3, 2024 · 3 comments · Fixed by #1305
Closed

Cannot specify Managed Node Group DiskSize when a launch template is created #1228

JustASquid opened this issue Jul 3, 2024 · 3 comments · Fixed by #1305
Assignees
@flostadler
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@JustASquid
Copy link
Contributor

What happened?

If you invoke any of the ManagedNodeGroup options that result in a custom launch template being created, disk size cannot be set, as AWS expects the disk size to be set on the launch template, not the original request.

Example

See relevant PR

Output of pulumi about

Latest

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@JustASquid JustASquid added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jul 3, 2024
@JustASquid JustASquid mentioned this issue Jul 3, 2024
Closed
@flostadler
Copy link
Contributor

Sorry you're running into this @JustASquid. I saw you already started working on a PR, thanks a lot for that!
Let me know if you have any questions or need help getting it over the finish line

@flostadler flostadler removed the needs-triage Needs attention from the triage team label Jul 8, 2024
@flostadler flostadler self-assigned this Jul 8, 2024
@flostadler flostadler mentioned this issue Aug 20, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Aug 21, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #1305 and shipped in release v2.7.9.

@flostadler
Copy link
Contributor

@JustASquid thanks again for your contribution! This is now released in v2.7.9

flostadler added a commit that referenced this issue Sep 4, 2024
@flostadler @JustASquid
Managed Node Group launch template disk size fix (#1305)
180f88b 
This fixes the handling of disk size changes when a custom launch
template is created for the MNG.
It is based on the Community PR #1229 by @JustASquid, I just added some
test fixes on top.

Fixes #1228

---------

Co-authored-by: Daniel West <daniel.west.279@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flostadler flostadler

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
3 participants
@flostadler @JustASquid @pulumi-bot