Managed Node Group launch template disk size fix #1305
Conversation
… support setting disk size when a MNG uses a custom launch template
…-size-fix' into feature/mng-launch-template-disk-size-fix
Does the PR have any schema changes?Looking good! No breaking changes found. |
examples/examples_nodejs_test.go
Outdated
| }, | ||
| }) | ||
|
|
||
| integration.ProgramTest(t, &test) |
There was a problem hiding this comment.
programTestWithExtraOptions will ignore delete failures
| @@ -1742,6 +1742,9 @@ function createManagedNodeGroupInternal( | |||
| let launchTemplate: aws.ec2.LaunchTemplate | undefined; | |||
| if (args.kubeletExtraArgs || args.bootstrapExtraArgs || args.enableIMDSv2) { | |||
| launchTemplate = createMNGCustomLaunchTemplate(name, args, core, parent, provider); | |||
|
|
|||
| // Disk size is specified in the launch template. | |||
| delete nodeGroupArgs.diskSize; | |||
There was a problem hiding this comment.
Not quite following control flow here, is diskSize deleted here coming from what the user supplied? Should we warn the user that the supplied value is a no-op in this case?
There was a problem hiding this comment.
It needs to be deleted because it will be set in the launch template. If you supply a custom launch template to the managed node group, the disk size needs to be set within the launch template and not on the node group
|
|
||
| // Defined in test managed-ng-disk-size | ||
| var desiredSizeGB int64 = 50 | ||
| assert.True(t, nodeEphemeralStorage.CmpInt64(desiredSizeGB*1_000_000_000) >= 0) |
|
The test failures are unrelated to this, the CI account is currently clogged up. Working on resolving this right now |
flostadler
deleted the
community-contrib/mng-launch-template-disk-size-fix
branch
|
This PR has been shipped in release v2.7.9. |
This fixes the handling of disk size changes when a custom launch template is created for the MNG. It is based on the Community PR #1229 by @JustASquid, I just added some test fixes on top. Fixes #1228 --------- Co-authored-by: Daniel West <daniel.west.279@gmail.com>
This fixes the handling of disk size changes when a custom launch template is created for the MNG.
It is based on the Community PR #1229 by @JustASquid, I just added some test fixes on top.
Fixes #1228