Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: consistently run build_sdk for golang #1267

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Jul 19, 2024

The build_sdk matrix was running for Go in some scenarios but not on cron, master, release. Specifically for release.yml this caused release failures since the workflows now assume that there is a step generating go.sdk.tar.gz artifact.

The build_sdk matrix was running for Go in some scenarios but not on cron, master, release. Specifically for release.yml
this caused release failures since the workflows now assume that there is a step generating go.sdk.tar.gz artifact.
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@t0yv0 t0yv0 requested a review from a team July 19, 2024 18:48
@t0yv0 t0yv0 changed the title Consistently run build_sdk for Go ci: consistently run build_sdk for Go Jul 19, 2024
@t0yv0 t0yv0 changed the title ci: consistently run build_sdk for Go ci: consistently run build_sdk for golang Jul 19, 2024
@t0yv0 t0yv0 merged commit ed7dcf4 into master Jul 19, 2024
45 checks passed
@t0yv0 t0yv0 deleted the t0yv0/fix-go-sdk-pub branch July 19, 2024 18:53
@t0yv0 t0yv0 mentioned this pull request Jul 19, 2024
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.7.6.

@mjeffryes mjeffryes added this to the 0.107 milestone Jul 24, 2024
flostadler pushed a commit that referenced this pull request Sep 4, 2024
The build_sdk matrix was running for Go in some scenarios but not on
cron, master, release. Specifically for release.yml this caused release
failures since the workflows now assume that there is a step generating
go.sdk.tar.gz artifact.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants