-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade terraform-provider-kafka to v0.5.4 #195
Conversation
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
Maintainer note: consult the runbook for dealing with any breaking changes. |
2054e1f
to
9e97c2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add token auto-mapping instead of more explicit resources?
Done! And removed the new resource from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like lost a number of examples, e.g. in sdk/dotnet/Acl.cs, sdk/dotnet/Quota.cs, sdk/dotnet/Topic.cs, sdk/go/kafka/acl.go, etc.
That's a bit of a regression for our users. Can we try and see what happened?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm that the missing docs were not removed upstream. If they should be in this provider, please make an issue in pulumi-kafka
and add it to pulumi/pulumi-terraform-bridge#1290. Lets not block on the missing docs.
LGTM
Docs regression seems to be caused by Mongey/terraform-provider-kafka@8b8961d. |
This PR was generated via
$ upgrade-provider pulumi/pulumi-kafka --kind=all
, with some manual changes required.Fixes Upgrade terraform-provider-kafka to v0.5.4 #194
Fixes scram user creation (Upgrade terraform-provider-kafka to v0.5.3) #192