Upgrade terraform-provider-kafka to v0.5.4 #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
Maintainer note: consult the runbook for dealing with any breaking changes. |
rquitales
force-pushed
the
upgrade-terraform-provider-kafka-to-v0.5.4
branch
from
2054e1f
to
9e97c2e
Compare
iwahbe
reviewed
Aug 25, 2023
lukehoban
approved these changes
Aug 25, 2023
Done! And removed the new resource from |
thomas11
reviewed
Aug 25, 2023
iwahbe
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Can you confirm that the missing docs were not removed upstream. If they should be in this provider, please make an issue in pulumi-kafka and add it to pulumi/pulumi-terraform-bridge#1290. Lets not block on the missing docs.
LGTM
|
Docs regression seems to be caused by Mongey/terraform-provider-kafka@8b8961d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated via
$ upgrade-provider pulumi/pulumi-kafka --kind=all, with some manual changes required.Fixes Upgrade terraform-provider-kafka to v0.5.4 #194
Fixes scram user creation (Upgrade terraform-provider-kafka to v0.5.3) #192