Cross-tests for PF's Configure

[iwahbe]

The interface for configure cross-tests is:

func Configure(
    t *testing.T, 
    schema schema.Schema,          // The provider's schema
    tfConfig map[string]cty.Value, // Config values for HCL/TF
    puConfig resource.PropertyMap, // Config values for Pulumi YAML/Pulumi
)

Because the mapping between tfConfig and puConfig is non-trivial, and to allow for secret injection, I have chosen to allow setting tfConfig and puConfig separately.

This is a pre-requisite for #2440.

---

When the underlying provider configuration doesn't match between Pulumi and TF, the error looks like this:

func TestFailure(t *testing.T) {
	crosstests.Configure(t,
		schema.Schema{Attributes: map[string]schema.Attribute{
			"k": schema.StringAttribute{Optional: true},
		}},
		map[string]cty.Value{"k": cty.StringVal("foo")},
		resource.PropertyMap{"k": resource.NewProperty("oo")},
	)
}

go test -test.run \^TestFailure\$
warning: resource:test_res.Docs received a non-zero custom value &{ [32]     false false} that is being ignored. Plugin Framework based providers do not yet support this feature.
--- FAIL: TestFailure (2.25s)
    configure.go:129: Pulumi.yaml:
        backend:
            url: file://./data
        name: project
        resources:
            p:
                properties:
                    k: oo
                type: pulumi:providers:test
        runtime: yaml
    --- FAIL: TestFailure/compare (0.00s)
        configure.go:174: 
            	Error Trace:	/Users/ianwahbe/go/src/github.com/pulumi/pulumi-terraform-bridge/pf/tests/internal/cross-tests/configure.go:174
            	Error:      	Not equal: 
            	            	expected: tfsdk.Config{Raw:tftypes.Value{typ:tftypes.Object{AttributeTypes:map[string]tftypes.Type{"k":tftypes.primitive{name:"String", _:[]struct {}(nil)}}, OptionalAttributes:map[string]struct {}(nil), _:[]struct {}(nil)}, value:map[string]tftypes.Value{"k":tftypes.Value{typ:tftypes.primitive{name:"String", _:[]struct {}(nil)}, value:"foo"}}}, Schema:schema.Schema{Attributes:map[string]schema.Attribute{"k":schema.StringAttribute{CustomType:basetypes.StringTypable(nil), Required:false, Optional:true, Sensitive:false, Description:"", MarkdownDescription:"", DeprecationMessage:"", Validators:[]validator.String(nil)}}, Blocks:map[string]schema.Block(nil), Description:"", MarkdownDescription:"", DeprecationMessage:""}}
            	            	actual  : tfsdk.Config{Raw:tftypes.Value{typ:tftypes.Object{AttributeTypes:map[string]tftypes.Type{"k":tftypes.primitive{name:"String", _:[]struct {}(nil)}}, OptionalAttributes:map[string]struct {}(nil), _:[]struct {}(nil)}, value:map[string]tftypes.Value{"k":tftypes.Value{typ:tftypes.primitive{name:"String", _:[]struct {}(nil)}, value:"oo"}}}, Schema:schema.Schema{Attributes:map[string]schema.Attribute{"k":schema.StringAttribute{CustomType:basetypes.StringTypable(nil), Required:false, Optional:true, Sensitive:false, Description:"", MarkdownDescription:"", DeprecationMessage:"", Validators:[]validator.String(nil)}}, Blocks:map[string]schema.Block(nil), Description:"", MarkdownDescription:"", DeprecationMessage:""}}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -18,3 +18,3 @@
            	            	     },
            	            	-    value: (string) (len=3) "foo"
            	            	+    value: (string) (len=2) "oo"
            	            	    }
            	Test:       	TestFailure/compare
FAIL
exit status 1
FAIL	github.com/pulumi/pulumi-terraform-bridge/pf/tests	3.059s

[VenelinMartinov]

LGTM, thanks for adding this! Out of scope here, but might be nice to add a simple resource test to make sure the library interface fits that nicely as well before adopting it more.

[codecov]

Codecov Report

Attention: Patch coverage is 71.15385% with 60 lines in your changes missing coverage. Please review.

Project coverage is 57.19%. Comparing base (e36cdc9) to head (f4038d0).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pf/tests/internal/cross-tests/util.go	40.90%	23 Missing and 3 partials ⚠️
pf/tests/internal/cross-tests/configure.go	80.00%	18 Missing and 3 partials ⚠️
pkg/tests/cross-tests/tfwrite.go	76.92%	11 Missing and 1 partial ⚠️
...f/tests/internal/providerbuilder/build_provider.go	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2467      +/-   ##
==========================================
+ Coverage   57.13%   57.19%   +0.06%     
==========================================
  Files         370      372       +2     
  Lines       51037    51243     +206     
==========================================
+ Hits        29160    29310     +150     
- Misses      20288    20336      +48     
- Partials     1589     1597       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[t0yv0]

Nice. Category theory.

[t0yv0]

Definitely out of scope but could be very nice. It could reference some proxy resource.

[t0yv0]

This is the framework bits right, not the coverage yet? If it adds coverage can you comment in-line to facilitate review? Appreciated!

[iwahbe]

This is the framework bits right, not the coverage yet? If it adds coverage can you comment in-line to facilitate review? Appreciated!

There is some coverage here, but it is not extensive. We have coverage for:

1. A plain string property
2. A secret string property
3. A plain bool property
4. A string ("false") passed to a bool property.

A follow-up PR will add actual coverage.

[pulumi-bot]

This PR has been shipped in release v3.92.0.