Move ./pf, ./testing and ./x/muxer under ./pkg #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2477 +/- ##
==========================================
- Coverage 61.77% 61.76% -0.01%
==========================================
Files 380 380
Lines 51263 51263
==========================================
- Hits 31667 31665 -2
- Misses 17780 17783 +3
+ Partials 1816 1815 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 11, 2024
blampe
added a commit
that referenced
this pull request
Oct 15, 2024
This removes three unnecessary modules: * pf/go.mod * x/muxer/go.mod * testing/go.mod And three unnecessary test modules: * pf/tests/go.mod * pkg/tests/go.mod * x/muxer/tests/go.mod This is intended to be merged with #2477 and #2480, which combine to make this a no-op for existing consumers. Refs #1445.
iwahbe
approved these changes
Oct 15, 2024
|
This PR has been shipped in release v3.93.0. |
|
This PR has been shipped in release v3.93.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
pf,testingandx/muxerunderpkg. This will allow us torestore modules at those paths in order to not break existing consumers.
More specifically, the new import paths are:
github.com/pulumi-terraform-bridge/pf→github.com/pulumi-terraform-bridge/v3/pkg/pfgithub.com/pulumi-terraform-bridge/x/muxer→github.com/pulumi-terraform-bridge/v3/pkg/x/muxergithub.com/pulumi-terraform-bridge/testing→github.com/pulumi-terraform-bridge/v3/pkg/x/testing(I put this underxsincetesting/xis the only package in this module)