Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PF provider options and accurate previews flag #2663

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Nov 22, 2024

This change adds provider options for the PF bridge, similar to the SDKv2 bridge provider options, as well as a flag for accurate bridge previews.

I've also enabled the flag for all diff tests.

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Nov 22, 2024

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (005a1f5) to head (2029b99).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/pf/tfbridge/provider_diff.go 50.00% 4 Missing and 2 partials ⚠️
pkg/pf/tfbridge/provider.go 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2663      +/-   ##
==========================================
- Coverage   69.43%   69.43%   -0.01%     
==========================================
  Files         301      301              
  Lines       38590    38613      +23     
==========================================
+ Hits        26796    26811      +15     
- Misses      10270    10277       +7     
- Partials     1524     1525       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_accurate_previews_feature_flag branch from e1824d4 to 074795a Compare November 22, 2024 19:18
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_accurate_previews_feature_flag branch from 7fb557c to 7203921 Compare November 25, 2024 12:23
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_accurate_previews_feature_flag branch 2 times, most recently from cf4362c to f86a647 Compare November 25, 2024 13:10
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_accurate_previews_feature_flag branch from f86a647 to 0268a08 Compare November 25, 2024 14:19
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_accurate_previews_feature_flag branch from 0268a08 to 4bea1d9 Compare November 25, 2024 15:24
Base automatically changed from vvm/pf_detailed_diff1 to master November 25, 2024 16:15
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_accurate_previews_feature_flag branch from 4bea1d9 to 2029b99 Compare November 25, 2024 16:51
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) November 25, 2024 16:51
@VenelinMartinov VenelinMartinov marked this pull request as draft November 25, 2024 17:32
auto-merge was automatically disabled November 25, 2024 17:32

Pull request was converted to draft

@VenelinMartinov VenelinMartinov marked this pull request as ready for review November 25, 2024 17:32
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) November 25, 2024 17:32
@VenelinMartinov VenelinMartinov merged commit 3ec60c3 into master Nov 25, 2024
31 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/pf_accurate_previews_feature_flag branch November 25, 2024 17:43
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.97.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants