Skip to content

Commit

Permalink
Remove preTest action as unit tests are run by default
Browse files Browse the repository at this point in the history
The `actions.preTest` modifier is no longer necessary since `ci-mgmt` now runs unit tests
in the `prerequisites` step. This change removes the redundancy caused by previously using
`actions.preTest` to work around the lack of default unit test execution.

This is necessary now because ci-mgmt recently started running `actions.preTest` as part
of release verification, and that job is not able to run `actions.preTest` step (missing
`gotestfmt`).

Fixes #676
  • Loading branch information
iwahbe committed Jan 9, 2025
1 parent 340f405 commit 6afdf91
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 14 deletions.
10 changes: 1 addition & 9 deletions .ci-mgmt.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,29 +5,21 @@ generate-nightly-test-workflow: true
plugins:
- name: std
version: "1.6.2"

- name: terraform
version: "1.0.16"
kind: converter

- name: aws
version: "4.26.0"
providerDefaultBranch: main
team: ecosystem
license:
ignore:
- github.com/hashicorp/terraform-provider-tls/shim

actions:
preTest:
- name: Run provider tests
run: |
cd provider && go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt
pulumiConvert: 1
registryDocs: true

releaseVerification:
nodejs: examples/private-key/ts
python: examples/private-key/py
dotnet: examples/private-key/dotnet
go: examples/private-key/go
integrationTestProvider: true
5 changes: 3 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,9 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
version: v2.5.0
- name: Run provider tests
run: |
cd provider && go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt
if: matrix.testTarget == 'local'
working-directory: provider
run: go test -v -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 .
- name: Run tests
if: matrix.testTarget == 'local'
run: cd examples && go test -v -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 4 .
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/verify-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@ jobs:
uses: ./.github/actions/setup-tools
with:
tools: pulumicli, nodejs, python, dotnet, go, java
- name: Run provider tests
run: |
cd provider && go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt
- name: Verify nodejs release
uses: pulumi/verify-provider-release@v1
with:
Expand Down

0 comments on commit 6afdf91

Please sign in to comment.