Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow failure: main #676

Closed
pulumi-bot opened this issue Jan 8, 2025 · 1 comment · Fixed by #678
Closed

Workflow failure: main #676

pulumi-bot opened this issue Jan 8, 2025 · 1 comment · Fixed by #678
Assignees
@iwahbe
Labels
kind/engineering Work that is not visible to an external user p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed

Comments

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Jan 8, 2025 •
edited
Loading

Workflow Failure

main has failed. See the list of failures below:
@pulumi-bot pulumi-bot added kind/engineering Work that is not visible to an external user needs-triage Needs attention from the triage team p1 A bug severe enough to be the next item assigned to an engineer labels Jan 8, 2025
@iwahbe iwahbe self-assigned this Jan 8, 2025
@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Jan 8, 2025
iwahbe added a commit that referenced this issue Jan 9, 2025
@iwahbe
Remove preTest action as unit tests are run by default
68c5d93 
The `actions.preTest` modifier is no longer necessary since `ci-mgmt` now runs unit tests
in the `prerequisites` step. This change removes the redundancy caused by previously using
`actions.preTest` to work around the lack of default unit test execution.

This is necessary now because ci-mgmt recently started running `actions.preTest` as part
of release verification, and that job is not able to run `actions.preTest` step (missing
`gotestfmt`).

Fixes #676
@iwahbe iwahbe mentioned this issue Jan 9, 2025
Merged
iwahbe added a commit that referenced this issue Jan 9, 2025
@iwahbe
Remove preTest action as unit tests are run by default
6afdf91 
The `actions.preTest` modifier is no longer necessary since `ci-mgmt` now runs unit tests
in the `prerequisites` step. This change removes the redundancy caused by previously using
`actions.preTest` to work around the lack of default unit test execution.

This is necessary now because ci-mgmt recently started running `actions.preTest` as part
of release verification, and that job is not able to run `actions.preTest` step (missing
`gotestfmt`).

Fixes #676
@iwahbe iwahbe closed this as completed in 8f57923 Jan 9, 2025
@pulumi-bot pulumi-bot added resolution/fixed This issue was fixed labels Jan 9, 2025
@pulumi-bot
Copy link
Contributor Author

This issue has been addressed in PR #678 and shipped in release v5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwahbe iwahbe

Labels
kind/engineering Work that is not visible to an external user p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove preTest action as unit tests are run by default pulumi/pulumi-tls
2 participants
@iwahbe @pulumi-bot