Remove preTest action as unit tests are run by default
#678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 8 8
=====================================
Misses 8 8 ☔ View full report in Codecov by Sentry. |
The `actions.preTest` modifier is no longer necessary since `ci-mgmt` now runs unit tests in the `prerequisites` step. This change removes the redundancy caused by previously using `actions.preTest` to work around the lack of default unit test execution. This is necessary now because ci-mgmt recently started running `actions.preTest` as part of release verification, and that job is not able to run `actions.preTest` step (missing `gotestfmt`). Fixes #676
iwahbe
force-pushed
the
iwahbe/remove-preTest
branch
from
68c5d93 to
6afdf91
Compare
flostadler
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
actions.preTestmodifier is no longer necessary sinceci-mgmtnow runs unit tests in theprerequisitesstep. This change removes the redundancy caused by previously usingactions.preTestto work around the lack of default unit test execution.This is necessary now because ci-mgmt recently started running
actions.preTestas part of release verification, and that job is not able to runactions.preTeststep (missinggotestfmt).Fixes #676