Skip to content

Commit

Permalink
Remove checking author when finding issues
Browse files Browse the repository at this point in the history
Now we're using the token for search it's a lot more reliable so we can remove the additional filtering.
  • Loading branch information
danielrbradley committed Nov 4, 2024
1 parent 376ff42 commit b44438e
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions upgrade/steps_helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -621,13 +621,10 @@ var getExpectedTargetFromIssues = stepv2.Func11E("From Issues", func(ctx context
"--repo="+name,
"--limit=100",
fmt.Sprintf("--search=%q", upgradeIssueToken),
"--json=title,number,author")
"--json=title,number")
titles := []struct {
Title string `json:"title"`
Number int `json:"number"`
Author struct {
Login string `json:"login"`
} `json:"author"`
}{}
err := json.Unmarshal([]byte(issueList), &titles)
if err != nil {
Expand All @@ -636,11 +633,6 @@ var getExpectedTargetFromIssues = stepv2.Func11E("From Issues", func(ctx context

var upgradeTargetIssues []UpgradeTargetIssue
for _, title := range titles {
isPulumiBot := title.Author.Login == "pulumi-bot"
isGitHubActions := title.Author.Login == "app/github-actions"
if !isPulumiBot && !isGitHubActions {
continue
}
_, nameToVersion, found := strings.Cut(title.Title, "Upgrade terraform-provider-")
if !found {
continue
Expand Down

0 comments on commit b44438e

Please sign in to comment.