Upgrade to Go 1.23 and golang.org/x to 0.21.0 #278
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ const ( | |
| func AutoAliasingMigration(resourcesFilePath, providerName string) (bool, error) { | ||
| // Create the AST by parsing src | ||
| fset := token.NewFileSet() | ||
| file, err := parser.ParseFile(fset, resourcesFilePath, nil, parser.ParseComments|parser.SkipObjectResolution) | ||
|
There was a problem hiding this comment. Syntactic object resolution is deprecated now including We don't need object resolution because we're doing ast manipulation and not analysis or resolving symbols across scopes. |
||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
@@ -96,7 +96,7 @@ func AutoAliasingMigration(resourcesFilePath, providerName string) (bool, error) | |
| } | ||
| c.InsertBefore(&ast.AssignStmt{ | ||
| Tok: tok, | ||
| Lhs: []ast.Expr{&ast.Ident{Name: "err"}}, | ||
|
There was a problem hiding this comment.
|
||
| Rhs: []ast.Expr{&ast.CallExpr{ | ||
| Fun: &ast.SelectorExpr{ | ||
| X: &ast.Ident{Name: "x"}, | ||
|
|
@@ -105,11 +105,11 @@ func AutoAliasingMigration(resourcesFilePath, providerName string) (bool, error) | |
| Args: []ast.Expr{ | ||
| &ast.UnaryExpr{ | ||
| Op: token.AND, | ||
| X: &ast.Ident{Name: "prov"}, | ||
| }, | ||
| &ast.CallExpr{ | ||
| Fun: &ast.SelectorExpr{ | ||
| X: &ast.Ident{Name: "prov"}, | ||
| Sel: &ast.Ident{Name: "GetMetadata"}, | ||
| }, | ||
| }, | ||
|
|
@@ -123,7 +123,7 @@ func AutoAliasingMigration(resourcesFilePath, providerName string) (bool, error) | |
| Sel: &ast.Ident{Name: "AssertNoErrorf"}, | ||
| }, | ||
| Args: []ast.Expr{ | ||
| &ast.Ident{Name: "err"}, | ||
| &ast.BasicLit{Kind: token.STRING, Value: "\"auto aliasing apply failed\""}, | ||
| }, | ||
| }}) | ||
|
|
@@ -140,7 +140,7 @@ func AutoAliasingMigration(resourcesFilePath, providerName string) (bool, error) | |
| Tok: token.VAR, | ||
| Specs: []ast.Spec{ | ||
| &ast.ValueSpec{ | ||
| Names: []*ast.Ident{{Name: "metadata"}}, | ||
| Type: &ast.ArrayType{Elt: &ast.Ident{Name: "byte // EMBED_DIRECTIVE_ANCHOR"}}, | ||
| }, | ||
| }, | ||
|
|
@@ -179,7 +179,7 @@ func AssertNoErrorMigration(resourcesFilePath, providerName string) (bool, error | |
| Sel: &ast.Ident{Name: "AssertNoErrorf"}, | ||
| }, | ||
| Args: []ast.Expr{ | ||
| &ast.Ident{Name: "err"}, | ||
| &ast.BasicLit{Kind: token.STRING, Value: "\"failed to apply auto token mapping\""}, | ||
| }, | ||
| }) | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addresses linter warning SA1029: should not use empty anonymous struct as key for value; define your own type to avoid collisions