Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify identifying provider upgrade issues #288

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Nov 4, 2024

  1. Use search token for finding issues to close
  2. Rename variable - name variable after the type.
  3. Remove checking author when finding issues
    • Now we're using the token for search it's a lot more reliable so we can remove the additional filtering.

Stacked on #287

Only search for token, not whole body. Tested running locally.
Name variable after the type.
Now we're using the token for search it's a lot more reliable so we can remove the additional filtering.
@danielrbradley danielrbradley requested review from iwahbe and a team November 4, 2024 11:25
@danielrbradley danielrbradley self-assigned this Nov 4, 2024
@VenelinMartinov
Copy link
Contributor

@danielrbradley looks like the test workflows have not been updated

Base automatically changed from fix-issue-search to main November 4, 2024 11:40
@danielrbradley
Copy link
Member Author

Tested locally to create this PR:

@danielrbradley danielrbradley merged commit ced55bc into main Nov 4, 2024
2 checks passed
@danielrbradley danielrbradley deleted the refine-provider-upgrade-issues branch November 4, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants