Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow <When /> to be used without a <PunditProvider /> #37

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Allow <When /> to be used without a <PunditProvider /> #37

merged 1 commit into from
Jul 2, 2023

Conversation

chrisalley
Copy link
Collaborator

@chrisalley chrisalley commented Jun 29, 2023 •
edited
Loading

Solves #2.

@chrisalley chrisalley force-pushed the allow-when-to-be-used-without-pundit-provider branch from 3f2c3eb to 6ddd54d Compare June 29, 2023 08:45
@chrisalley chrisalley requested a review from johno June 29, 2023 08:45
@chrisalley chrisalley force-pushed the allow-when-to-be-used-without-pundit-provider branch from 6ddd54d to f69b847 Compare June 29, 2023 09:00
johno
johno approved these changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! One question/consideration but I wouldn't consider it a blocker if you want to just 🚢

src/react/when.tsx Outdated Show resolved Hide resolved
@chrisalley chrisalley force-pushed the allow-when-to-be-used-without-pundit-provider branch from f69b847 to abd0ebb Compare July 2, 2023 05:17
@chrisalley chrisalley merged commit 1f8f9c3 into master Jul 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the allow-when-to-be-used-without-pundit-provider branch July 2, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johno johno johno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisalley @johno