Skip to content

Make relative names in AXFR into FQDN #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

niclan
Copy link

@niclan niclan commented Aug 26, 2024

In the zonetransfer provider the RHS of a CNAME may be a relative name not necessarily a FQDN. So for example

www.example.com CNAME webserver

instead of

www.example.com CNAME webserver.example.com.

Note significant ending . in the second example. This PR makes relative names into FQDNs.

Copy link

@niclan
Copy link
Author

niclan commented Aug 26, 2024

I was unable to get this into a list comprehension, sorry.

@imnotbrandon
Copy link
Contributor

Hi, thanks for the contribution!

Whilst testing this, I've discovered that false negatives are produced because we don't recursively resolve records.

This isn't an issue introduced by your code, but I thought you should be aware given the context. I've already got a working fix so I'll merge that in separately once it's properly tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants