(CAT-1618) - Fix issue with code coverage in nightlies #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
CAT-1618-add_in_code_coverage
branch
3 times, most recently
from
316bc3f to
820b6cf
Compare
Prior to this commit, code coverage reports would attempt to upload from the nightlies despite no code coverage reports being generated. This is because we only run code coverage in the ci.yml job, and not nightly.yml. This PR adds another conditional to the upload coverage reports to Codecov step, to ensure this step is only run when a coverage rake_task has been supplied.
jordanbreen28
force-pushed
the
CAT-1618-add_in_code_coverage
branch
from
820b6cf to
ef8fef8
Compare
david22swan
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this PR, code coverage reports would attempt to upload from the nightlies despite no code coverage reports being generated. This is because we only run code coverage in the ci.yml job, and not nightly.yml.
This PR adds another conditional to the upload coverage reports to Codecov step, to ensure this step is only run when a coverage rake_task has been supplied.
Additional Context
You can see here that this step does not execute anymore when the coverage rask_task task is not run here https://github.com/puppetlabs/puppet-modulebuilder/actions/runs/7540032930/job/20523775839?pr=68.
When the coverage rask_task is run however, it executes like normal see here https://github.com/puppetlabs/puppet-modulebuilder/actions/runs/7540019355/job/20523734764
Related Issues (if any)
Mention any related issues or pull requests.
Checklist