Fix puppet-lint namespace clash with new puppetlabs-lint gem #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSPatton
changed the title
GSPatton
changed the title
|
@GSPatton can you please rebase? I think we should test one of the external plugins with this branch before merging. |
Currently, the new puppet-lint gem and the old one clash as both compete for the PuppetLint namespace. This initial commit aims to solve this by intorducing the puppetlabs directory in lib so that resources are found in lib/puppetlabs/puppet-lint rather than lib/puppet-lint. This method is being tested first to avoid introducing changes that would require users to update their puppet-lint resource definitions
…ll test on broken vox lint plugin PRs
GSPatton
force-pushed
the
fix-namespace-clash
branch
from
3b7fbd8 to
5fe537f
Compare
|
hi @bastelfreak. Will test that out now |
ekohl
suggested changes
Nov 14, 2023
|
Just a thought: perhaps pick a name that really is different, like |
…int/plugins rather than lib/puppetlabs-lint/plugins - sacraficing consistency in naming here for minimal impact on users
|
Hi @ekohl, instead of changing all instances of |
|
Closing in favour of #177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the new puppet-lint gem and the old one clash as both compete for the PuppetLint namespace. This initial commit aims to solve this by intorducing the puppetlabs directory in lib so that resources are found in lib/puppetlabs/puppet-lint rather than lib/puppet-lint. This method is being tested first to avoid introducing changes that would require users to update their puppet-lint resource definitions
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist