Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) - Release prep v4.2.2 #178

Merged
merged 1 commit into from
Nov 21, 2023
Merged

(maint) - Release prep v4.2.2 #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/puppet-lint/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
class PuppetLint
VERSION = '5.0.0'.freeze
VERSION = '4.2.2'.freeze
end
5 changes: 4 additions & 1 deletion puppet-lint.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@ $LOAD_PATH.push(File.expand_path('lib', __dir__))
require 'puppet-lint/version'

Gem::Specification.new do |spec|
spec.name = 'puppetlabs-puppet-lint'
spec.name = 'puppet-lint'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was merged quite fast. I would have suggested to revert the original commit instead. Or at least do the change in a dedicated PR and not the release PR. I think the renaming is a quite significant change and now it won't appear in the changelog?

spec.version = PuppetLint::VERSION.dup
spec.homepage = 'https://github.com/puppetlabs/puppet-lint/'
spec.summary = 'Ensure your Puppet manifests conform with the Puppetlabs style guide'
spec.description = <<-EOF
Checks your Puppet manifests against the Puppetlabs style guide and alerts you to any discrepancies.
Note: Support for this gem has been moved under the github rubygems registry and as such any future updates from
the Puppet team will be released under `https://github.com/orgs/puppetlabs/packages/rubygems/puppet-lint`.
EOF

spec.files = Dir[
Expand All @@ -27,6 +29,7 @@ Gem::Specification.new do |spec|
'Community Contributors',
]
spec.email = [
'tim@sharpe.id.au',
'modules-team@puppet.com',
]
spec.license = 'MIT'
Expand Down