Add configuration options to filter facts out in puppetdb termini #3998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset adds two configuration options used by the facts PuppetDB indirector: * fact_names_blocklist * fact_names_blocklist_regex They can be used to configure a list of fact names that will never be sent to PuppetDB, based on exact fact names or regular expressions.
|
|
|
CLA is already signed due to agreement between puppetlabs and CERN IT. |
|
Can one of the admins verify this patch? |
|
I realise since this patch was originally written PuppetDB itself can be configured to block facts however we have been running this way for years and dropping the facts earlier makes sense. |
|
For anyone that ends up finding this PR as well. PuppetDB itself cannot be configured to block structured facts due to #3975. |
djuarezg
added a commit
to djuarezg/puppetdb
that referenced
this pull request
Sep 9, 2025
This patch works as well for structured facts, not like puppetlabs#3998
djuarezg
added a commit
to djuarezg/puppetdb
that referenced
this pull request
Sep 9, 2025
This patch works as well for structured facts, not like puppetlabs#3998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds two configuration options used by the facts PuppetDB indirector:
They can be used to configure a list of fact names that will never be sent to PuppetDB, based on exact fact names or regular expressions.
This MR obsoletes - #2634