Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent sources with zero prefix length being applied every agent run #1189

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

nabertrand
Copy link
Contributor

Summary

Prevent source and destination values with a prefix length of zero causing the Puppet agent to attempt corrections on every run

Additional Context

See #1188

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@nabertrand nabertrand requested a review from a team as a code owner February 2, 2024 19:28
@praj1001
Copy link
Contributor

@nabertrand , Can u please fix the specs ??

@trevorrea
Copy link

@praj1001 Can you not just fix it? It's literally removing a space from:-

! [:source, :destination].include?(property_name)

to

![:source, :destination].include?(property_name)

@nabertrand
Copy link
Contributor Author

@nabertrand , Can u please fix the specs ??

@praj1001 I merged with main and fixed the rubocop warning

@EnigmaticCypher
Copy link

@malikparvez can this be approved & merged please? Or do I need to force the issue by getting a ticket raised to perforce under an enterprise support contract? The community provided a fix for this almost a full year ago and multiple issues in this repository have been raised about it.

@praj1001 praj1001 merged commit fb991c5 into puppetlabs:main Nov 27, 2024
50 checks passed
@praj1001
Copy link
Contributor

@nabertrand @trevorrea @EnigmaticCypher, Approved & Merged.

@trevorrea
Copy link

@praj1001 can we also get a release pushed to Puppet Forge please?

@sahaqaa
Copy link

sahaqaa commented Dec 2, 2024

When approx it (new version of module, which includes this fix) will be released to Puppet Forge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants